Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the -t flag #38

Merged
merged 3 commits into from
Jun 17, 2023
Merged

Remove the -t flag #38

merged 3 commits into from
Jun 17, 2023

Conversation

leighmcculloch
Copy link
Owner

@leighmcculloch leighmcculloch commented Jan 16, 2023

What

Remove the -t flag.

Why

Newer versions of the singlechecker, which is the library that creates the CLI interface, have a -test=[true|false] option. It's confusing that the CLI interface now has -t and -test.

This change is somewhat problematic to make, because the two flags work contrary to each other. The CLI currently has tests disabled and -t enables them. However, the -test flag works in reverse. Singlechecker assumes tests are enabled by default and -test=false disables them.

Another reason we should remove the -t flag is because it doesn't interact well with the multichecker setup where multiple analyzers are combined together. Analyzers expect tests to be enabled and to let the analysis framework filter tests if flagged.

@leighmcculloch
Copy link
Owner Author

This is a breaking change, which may be inconvenient. Should we hold this for a v2? Put it through now because it's in some ways a bug at this point that it's there?

@leighmcculloch leighmcculloch marked this pull request as ready for review January 16, 2023 06:54
@leighmcculloch leighmcculloch merged commit a9cb750 into master Jun 17, 2023
@leighmcculloch leighmcculloch deleted the tests branch June 17, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant