Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove the -t flag.
Why
Newer versions of the singlechecker, which is the library that creates the CLI interface, have a
-test=[true|false]
option. It's confusing that the CLI interface now has-t
and-test
.This change is somewhat problematic to make, because the two flags work contrary to each other. The CLI currently has tests disabled and
-t
enables them. However, the-test
flag works in reverse. Singlechecker assumes tests are enabled by default and-test=false
disables them.Another reason we should remove the
-t
flag is because it doesn't interact well with the multichecker setup where multiple analyzers are combined together. Analyzers expect tests to be enabled and to let the analysis framework filter tests if flagged.