Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scala version specific source directories #347

Merged
merged 4 commits into from
Sep 14, 2021
Merged

scala version specific source directories #347

merged 4 commits into from
Sep 14, 2021

Conversation

gregor-i
Copy link
Contributor

@theon I've implemented scala version specific source directories as suggested in your comment.

Regarding scala.js: as far as I know, scala.js won't support scala 3 any time soon. Source

@gregor-i gregor-i requested a review from theon as a code owner September 14, 2021 14:08
@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

❗ No coverage uploaded for pull request base (scala3-type-class-derivation@8eb188d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                       Coverage Diff                       @@
##             scala3-type-class-derivation     #347   +/-   ##
===============================================================
  Coverage                                ?   95.21%           
===============================================================
  Files                                   ?       31           
  Lines                                   ?     1171           
  Branches                                ?       37           
===============================================================
  Hits                                    ?     1115           
  Misses                                  ?       56           
  Partials                                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8eb188d...8795125. Read the comment docs.

@theon theon merged commit 664b6a4 into lemonlabsuk:scala3-type-class-derivation Sep 14, 2021
@theon
Copy link
Member

theon commented Sep 14, 2021

Thanks. This looks great!

Can see all the Scala 2 builds are passing and Scala3 is just failing because of the scoverage plugin, which I am happy to disable for Scala3 for the meantime.

I'll take another look at Scala.js as that post seems to suggest it is already supported for Scala3

What did it take to add Scala.js support in Scala 3? How did we manage to do the necessary work in less than 3 months, whereas Scala.js for Scala 2 took 7 years to mature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants