sendpayment Part 2: Channel open, Get invoice
#58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxFangX
force-pushed
the
max/sendpayment-2
branch
from
2212a5f to
c81010b
Compare
MaxFangX
force-pushed
the
max/sendpayment-2
branch
from
c81010b to
79b78fa
Compare
MaxFangX
changed the title
sendpayment Part 2sendpayment Part 2: Channel open, Get invoice
phlip9
approved these changes
Oct 7, 2022
| // TODO FIXME XXX: This trait requires that event handling *finishes* | ||
| // before returning from this function, but LDK #1674 (async event | ||
| // handling) isn't implemented yet. For now, we carry out the event | ||
| // handling in a spawned task, but this *must* be fixed eventually. |
There was a problem hiding this comment.
why spawn the task now before the ldk feature is usable?
There was a problem hiding this comment.
This was causing a panic 'cannot start a Tokio runtime within a Tokio runtime' when running the node directly (not as a process) in the smoketest
There was a problem hiding this comment.
huh, don't really understand how that's happening...
There was a problem hiding this comment.
maybe should figure rt issue out rather than enabling this?
MaxFangX
force-pushed
the
max/sendpayment-2
branch
from
a8dd921 to
895e54a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Definitely review by commit. Commit names pretty clearly summarize what was changed.