Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: affiliation page final review #126

Open
wants to merge 4 commits into
base: testnet
Choose a base branch
from

Conversation

blessingbytes
Copy link

@blessingbytes blessingbytes commented Feb 21, 2025

Gm @Marchand-Nicolas kindly review :)
Everything looks fine now

close: #108

Copy link

vercel bot commented Feb 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
starknet-id ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 10:31am

Copy link

vercel bot commented Feb 21, 2025

@blessingbytes is attempting to deploy a commit to the LFG Labs Team on Vercel.

A member of the Team first needs to authorize it.

@blessingbytes
Copy link
Author

closes #108

@blessingbytes
Copy link
Author

@Marchand-Nicolas kindly review

Copy link
Collaborator

@Marchand-Nicolas Marchand-Nicolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On mobile the text goes on top of the header on the main page (because we use the same component you updated) on mobile

Screenshot 2025-02-22 at 10 10 16 PM

@Marchand-Nicolas Marchand-Nicolas added the ❌ Change request Change requested from reviewer label Feb 22, 2025
@blessingbytes
Copy link
Author

@Marchand-Nicolas kindly review :)

Copy link
Collaborator

@Marchand-Nicolas Marchand-Nicolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost perfect! Well done :)

With your PR, the header of the affiliate page is not centered anymore on mobile:
Screenshot 2025-02-24 at 6 23 09 PM

@blessingbytes
Copy link
Author

@Marchand-Nicolas kindly review :)

@Marchand-Nicolas
Copy link
Collaborator

@Marchand-Nicolas kindly review :)

Hello! I think you forgot to push, I don't see the commit. A good practice to gain time is to come back a few minute after pushing, and check it automatically deployed successfully (and that way, you can check how it renders in production)

@Marchand-Nicolas
Copy link
Collaborator

@blessingbytes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❌ Change request Change requested from reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Affiliation page - Final review
2 participants