fix: adding check to getAddressFromStarkName

lfglabs-dev · Jan 27, 2025 · 13e1493 · 13e1493
1 parent a6030c3
commit 13e1493
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/packages/core/__test__/default.test.ts b/packages/core/__test__/default.test.ts
@@ -224,6 +224,21 @@ describe("test starknetid.js sdk", () => {
     expect(address).toBe("0x0");
   });
 
+  test("getAddressFromStarkName should fail because domain is not a stark domain", async () => {
+    const starknetIdNavigator = new StarknetIdNavigator(
+      provider,
+      constants.StarknetChainId.SN_SEPOLIA,
+      {
+        naming: NamingContract,
+        identity: IdentityContract,
+      },
+    );
+    expect(starknetIdNavigator).toBeInstanceOf(StarknetIdNavigator);
+    await expect(
+      starknetIdNavigator.getAddressFromStarkName("test.eth"),
+    ).rejects.toThrow("Domain is not a .stark domain");
+  });
+
   test("getStarkName should fail because address has no starkname", async () => {
     const starknetIdNavigator = new StarknetIdNavigator(
       provider,

diff --git a/packages/core/src/starknetIdNavigator/default.ts b/packages/core/src/starknetIdNavigator/default.ts
@@ -52,6 +52,10 @@ export class StarknetIdNavigator implements StarknetIdNavigatorInterface {
   }
 
   public async getAddressFromStarkName(domain: string): Promise<string> {
+    if (!isStarkDomain(domain)) {
+      throw new Error("Domain is not a .stark domain");
+    }
+
     const contract =
       this.StarknetIdContract.naming ?? getNamingContract(this.chainId);
     const encodedDomain = encodeDomain(domain).map((elem) => elem.toString(10));