Fix Seg-fault when setting proxy username + password #1181
Merged
+47
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simue
changed the title
COM8
requested changes
Feb 16, 2025
There was a problem hiding this comment.
@simue thank you very much for fixing this!
Please also apply the change for those lines here:
https://github.com/libcpr/cpr/blob/master/cpr/session.cpp#L665
I also noticed that this is copy/paste code here so it could be singled out into its own function.
|
Also the clang tidy warning can be ignored in this case although a better way would be to replace returning a |
|
I went for returning a const ref to the SecureString, so we don´t do a copy to std::string, leading to the credentials potentially staying in memory |
COM8
approved these changes
Feb 17, 2025
COM8
added a commit
that referenced
this pull request
Feb 17, 2025
Fix Seg-fault when setting proxy username + password
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providing a char* to underlying data of string_view instead string_view itself to curl api.
Fixes #1180