-
Notifications
You must be signed in to change notification settings - Fork 18
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix doc bug w/ one(default=Exception)
Pointed out by @zwn at gratipay/gratipay.com#2106 (comment)
- Loading branch information
1 parent
55c69c0
commit 935feba
Showing
1 changed file
with
2 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
935feba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the
default
should never be raised. Instead another param called mayberaises
should be added to make it clear at the call site that the function raises.935feba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zwn Ticketed as #38. Let's discuss there instead of on this commit.