This repository has been archived by the owner on Sep 6, 2022. It is now read-only.
Use PeerRecord value instead of pointer in EvtLocalPeerRecordUpdated
#113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulk
approved these changes
Feb 10, 2020
yusefnapora
changed the title
PeerRecord value instead of pointer in EvtLocalPeerRecordUpdated
|
nit: “embed” has a very specific meaning in go. In this case we’re not embedding the struct, we’re just changing the field type to a value instead of a pointer. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small update to #73 that changes the
EvtLocalPeerRecordUpdatedevent struct so that it embeds aPeerRecordvalue, instead of a pointer to aPeerRecord. This prevents record from being modified by receivers.