Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in oversubscription pruning D_out constraint #344

Merged
merged 1 commit into from
May 26, 2020

Conversation

vyzo
Copy link
Collaborator

@vyzo vyzo commented May 25, 2020

If some outbound peers were already part of the selection and near the end of it, they could slide off when rotating in outbound peers from outside the selection.
This fixes the issue, by doing a first pass and rotating to the front outbound peers already part of the selection.

@vyzo vyzo requested review from yusefnapora and daviddias May 25, 2020 07:42
Copy link
Contributor

@yusefnapora yusefnapora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch 👍

@vyzo vyzo merged commit 9a1171a into master May 26, 2020
@vyzo vyzo deleted the fix/oversubscription-outbound branch May 26, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants