This repository has been archived by the owner on Feb 24, 2021. It is now read-only.
share the buffer pool. #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
This was referenced Nov 17, 2017
Stebalien
force-pushed
the
fix/reuse-pool
branch
from
5915afc to
9f79cbc
Compare
Before, we were copying it (dangerously, locks and stuff), into every writer. Now, we share it (like we should...). note: I'm not even sure if we should be using buffer pools (the allocator may be faster in this case) but that's another issue.
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we were copying it (dangerously, locks and stuff), into every writer. Now, we share it (like we should...).
note: I'm not even sure if we should be using buffer pools (the allocator may be faster in this case) but that's another issue.