move some functions from go-sockaddr here, remove go-sockaddr dependency #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
remove-sockaddr-dependency
branch
from
60674d6 to
a626e45
Compare
willscott
approved these changes
Jan 15, 2022
This was referenced Jan 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, go-netroute is the only package in our stack using go-sockaddr, and it's only doing so for a few function calls on Windows.
If we move these functions (less than 150 LOC) here, we can deprecate go-sockaddr, moving us one tiny step forward in our repo consolidation effort.
Also replace
itodanddtoi(https://github.com/libp2p/go-sockaddr/blob/5fafa0f91376612e1e57921afe72602c9b8b3431/net/net.go#L316-L350) with their standard library equivalents.