This repository has been archived by the owner on May 26, 2022. It is now read-only.
use the ResourceManager #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyzo
reviewed
Dec 22, 2021
tcp.go
Outdated
| return nil, err | ||
| } | ||
| if err := connScope.SetPeer(p); err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
we need a Done if it fails I think -- should we do that automagically?
There was a problem hiding this comment.
yeah we definitely need a Done, we own it at this point.
marten-seemann
force-pushed
the
rcmgr
branch
from
45adbbd to
fe24386
Compare
marten-seemann
commented
Dec 31, 2021
marten-seemann
force-pushed
the
rcmgr
branch
from
fe24386 to
8c0f4d6
Compare
69 tasks
marten-seemann
force-pushed
the
rcmgr
branch
8 times, most recently
from
7ee275c to
5b0f844
Compare
marten-seemann
force-pushed
the
rcmgr
branch
2 times, most recently
from
729a43e to
e760df1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on libp2p/go-libp2p-transport-upgrader#99.