Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.

fix: transport should not handle connection if upgradeInbound throws #191

Merged
merged 1 commit into from
Dec 31, 2019
Merged

fix: transport should not handle connection if upgradeInbound throws #191

merged 1 commit into from
Dec 31, 2019

Conversation

vasco-santos
Copy link
Member

@vasco-santos vasco-santos commented Dec 20, 2019 •
edited
Loading

@vasco-santos vasco-santos force-pushed the fix/transport-should-not-handle-connection-if-upgradeInbound-throws branch from 39662b0 to 31aa31a Compare December 20, 2019 18:24
@vasco-santos vasco-santos marked this pull request as ready for review December 20, 2019 18:25
@vasco-santos vasco-santos mentioned this pull request Dec 30, 2019
Merged
jacobheun
jacobheun approved these changes Dec 30, 2019
View reviewed changes
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

@vasco-santos vasco-santos merged commit 865a2a7 into master Dec 31, 2019
@vasco-santos vasco-santos deleted the fix/transport-should-not-handle-connection-if-upgradeInbound-throws branch December 31, 2019 10:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacobheun jacobheun jacobheun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vasco-santos @jacobheun