Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Ensure services indicate their dependencies through identifiers #2263

Closed
maschad opened this issue Nov 29, 2023 · 0 comments · Fixed by #2586
Closed

feat: Ensure services indicate their dependencies through identifiers #2263

maschad opened this issue Nov 29, 2023 · 0 comments · Fixed by #2586
Labels
dependencies Pull requests that update a dependency file dx Developer Experience topic/dependencies Topic dependencies

Comments

@maschad
Copy link
Member

maschad commented Nov 29, 2023 •
edited
Loading

As suggested in #2135 In order for services to indicate their dependencies so that consumers can utilize the libp2p stack effectively, we should have each service return a list of other services it requires, which would be verified on startup.

Related: #1762
@maschad maschad added the need/triage Needs initial labeling and prioritization label Nov 29, 2023
@maschad maschad moved this to 🛠️ Todo in js-libp2p Nov 29, 2023
@maschad maschad added dx Developer Experience topic/dependencies Topic dependencies dependencies Pull requests that update a dependency file and removed need/triage Needs initial labeling and prioritization labels Nov 29, 2023
@achingbrain achingbrain moved this from 🛠️ Todo to 🤨Needs Investigation in js-libp2p May 14, 2024
@dhuseby dhuseby moved this from 🤨Needs Investigation to 🛠️ Todo in js-libp2p May 14, 2024
achingbrain added a commit that referenced this issue Jun 12, 2024
@achingbrain
feat: check service dependencies on startup
7eaa025 
Allows services to optionally define the capabilities they provide to the
rest of libp2p and also the capabilities they require from other services.

This allows, for example, the `WebRTC` transport to require the `CircuitRelay`
transport to be present, or `KAD-DHT` (or anything that uses a topology)
to require the identify protocol.

Fixes #2263
Refs #2135
@achingbrain achingbrain mentioned this issue Jun 12, 2024
Merged
3 tasks
achingbrain added a commit that referenced this issue Jun 12, 2024
@achingbrain
feat: check service dependencies on startup
4b23377 
Allows services to optionally define the capabilities they provide to the
rest of libp2p and also the capabilities they require from other services.

This allows, for example, the `WebRTC` transport to require the `CircuitRelay`
transport to be present, or `KAD-DHT` (or anything that uses a topology)
to require the identify protocol.

Fixes #2263
Refs #2135
achingbrain added a commit that referenced this issue Jun 12, 2024
@achingbrain
feat: check service dependencies on startup
db7d5e5 
Allows services to optionally define the capabilities they provide to the
rest of libp2p and also the capabilities they require from other services.

This allows, for example, the `WebRTC` transport to require the `CircuitRelay`
transport to be present, or `KAD-DHT` (or anything that uses a topology)
to require the identify protocol.

Fixes #2263
Refs #2135
achingbrain added a commit that referenced this issue Jun 13, 2024
@achingbrain
feat: check service dependencies on startup (#2586)
d1f1c2b 
Allows services to optionally define the capabilities they provide to the
rest of libp2p and also the capabilities they require from other services.

This allows, for example, the `WebRTC` transport to require the `CircuitRelay`
transport to be present, or `KAD-DHT` (or anything that uses a topology)
to require the identify protocol.

Fixes #2263
Refs #2135
@github-project-automation github-project-automation bot moved this from 🛠️ Todo to 🎉Done in js-libp2p Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file dx Developer Experience topic/dependencies Topic dependencies
Projects
js-libp2p
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: check service dependencies on startup libp2p/js-libp2p
1 participant
@maschad