Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow custom services to depend on each other #2588

Merged
merged 2 commits into from
Jun 12, 2024
Merged

fix: allow custom services to depend on each other #2588

merged 2 commits into from
Jun 12, 2024

Conversation

achingbrain
Copy link
Member

Derive the type of the components arg from a union of the internal components plus the service map type.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
fix: fix up types to allow custom services to depend on each other
92bfe2f 
Derive the type of the components arg from a union of the internal
components plus the service map type.
@achingbrain achingbrain requested a review from a team as a code owner June 12, 2024 13:10
@achingbrain achingbrain changed the title fix: fix up types to allow custom services to depend on each other fix: allow custom services to depend on each other Jun 12, 2024
@achingbrain achingbrain merged commit 0447913 into main Jun 12, 2024
24 checks passed
@achingbrain achingbrain deleted the fix/simplify-types branch June 12, 2024 14:04
@achingbrain achingbrain mentioned this pull request Jun 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@achingbrain