refactor: examples-browser #508
Conversation
vasco-santos
force-pushed
the
refactor/examples-browser
branch
from
145c336 to
461cfad
Compare
jacobheun
force-pushed
the
refactor/async-await
branch
from
374ceb4 to
45f4702
Compare
vasco-santos
force-pushed
the
refactor/examples-browser
branch
from
461cfad to
965d3bf
Compare
|
Added information for people to run a signaling server |
There was a problem hiding this comment.
Some small content changes. @vasco-santos have you gotten this running locally? I had two peers and they weren't able to connect over a local signaling server. I turned the debug logs on and got quite a few dialing failures.
|
I tried it out with the latest changes and two local peers, but the dial hangs forever. Do you have any idea on what is going on? |
jacobheun
force-pushed
the
refactor/examples-browser
branch
from
0d661dc to
a63e476
Compare
Co-Authored-By: Jacob Heun <[email protected]>
docs(examples): redo the browser readme
jacobheun
force-pushed
the
refactor/examples-browser
branch
from
501eae3 to
1df7472
Compare
|
I've reworked the browser example, it's now based off of the js-ipfs browser-parcel example, and the code has been simplified to a single file. The issues with webrtc and websockets have been resolved, this is ready for a final review. |
|
|
||
| Start by installing libp2p's dependencies. | ||
| In order to run the example, first install the dependencies from same directory as this README: |
There was a problem hiding this comment.
You also need to ensure dependencies in the root of the project are installed since it depends on libp2p: "../../"
There was a problem hiding this comment.
NPM should actually handle the install for you, I've verified this works a few times after clearing node modules from the project root.
Co-Authored-By: Alan Shaw <[email protected]>
* refactor: examples-browser * chore: add information to use signalling server * chore: apply suggestions from code review Co-Authored-By: Jacob Heun <[email protected]> * chore: update deps * docs: refactor libp2p browser example * docs(examples): add back websockets and boostrap nodes docs(examples): redo the browser readme * fix: handle edge case of connections closing early * chore: fix lint * chore: update example deps and readme * chore: update webrtc-star * chore: apply suggestions from code review Co-Authored-By: Alan Shaw <[email protected]> Co-authored-by: Jacob Heun <[email protected]> Co-authored-by: Alan Shaw <[email protected]>
This PR refactors the
browserexample to the refactored asyncjs-libp2p.