[mplex] Tweak default config and yield before exceeding buffer limits. #1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
approved these changes
Nov 9, 2020
mxinden
reviewed
Nov 9, 2020
| already filled a substream buffer, to give the current task a | ||
| chance to read from the buffer(s) before the `MaxBufferBehaviour` | ||
| takes effect. This is primarily relevant for | ||
| `MaxBufferBehaviour::ResetStream`. |
There was a problem hiding this comment.
Suggested change
| `MaxBufferBehaviour::ResetStream`. | |
| `MaxBufferBehaviour::ResetStream`. | |
| [PR 1825](https://github.com/libp2p/rust-libp2p/pull/1825/). |
There was a problem hiding this comment.
Oh, I was too late. I will include this in #1829.
There was a problem hiding this comment.
Oops, sorry, thanks for doing that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a small follow-up to #1814 (comment). It contains the following changes:
MplexConfigusesMaxBufferBehaviour::Blockas I think it is the better default.poll_next_stream) or reading from a particular substream (poll_read_stream), we yield the current task, allowing it to be polled again to have a chance to read from the buffers before theMaxBufferBehaviourtakes effect.