Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(libp2p-quic): pin and update tls prerelease dep #3548

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

ozwaldorf
Copy link
Contributor

@ozwaldorf ozwaldorf commented Mar 3, 2023

Description

Pin libp2p-quic's tls prerelease dependency and update it

Notes

Found out the 0.50.1 is still broken due to quic also having a unconstrained dependency for libp2p-tls prerelease cc @thomaseizinger if you want to do the backport again for 0.50

Links to any relevant issues

Continue fixing #3537

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@ozwaldorf
Copy link
Contributor Author

ozwaldorf commented Mar 3, 2023

Just a thought, maybe leveraging workspace dependencies may also ease some maintenance pain when updating versions in the future

@ozwaldorf ozwaldorf changed the title fix(quic): pin tls prerelease dep (and update it) fix(libp2p-quic): pin tls prerelease dep (and update it) Mar 3, 2023
@ozwaldorf ozwaldorf changed the title fix(libp2p-quic): pin tls prerelease dep (and update it) fix(libp2p-quic): pin and update tls prerelease dep Mar 3, 2023
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@mxinden mxinden added the send-it label Mar 3, 2023
@mergify mergify bot merged commit 050504f into libp2p:master Mar 3, 2023
@mxinden
Copy link
Member

mxinden commented Mar 3, 2023

@thomaseizinger if you want to do the backport again for 0.50

I am not sure how we can backport this change.

856ede0 would backport pinning the libp2p-tls version in libp2p-quic. Problem is, what version bump to choose for libp2p-quic? v0.7.0-alpha-2 is already taken. Thoughts?

@ozwaldorf
Copy link
Contributor Author

ozwaldorf commented Mar 3, 2023

I think we can use a lower number that hasn't been used yet, like v0.7.0-alpha.0. will PR in a sec 😄

@ozwaldorf ozwaldorf deleted the patch-2 branch March 4, 2023 00:42
@thomaseizinger
Copy link
Contributor

The other option may be to yank all other versions and publish new ones starting from alpha.2.

@ozwaldorf
Copy link
Contributor Author

ozwaldorf commented Mar 6, 2023

The other option may be to yank all other versions and publish new ones starting from alpha.2.

If we do this, we need to also release an update for 0.51.0 to prevent it from picking the wrong version again, since its still unpinned there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants