feat(swarm): separate errors for pending inbound and outbound connection

[akaladarshi]

Description

• Removes the PendingConnectionError
• Create separate errors for PendingOutboundConnectionError and PendingInboundConnectionError

Fixes: #2767

Notes & open questions

Change checklist

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• A changelog entry has been made in the appropriate crates

[akaladarshi]

Hey @elenaf9 @jxs,

Can someone give me few pointer about why the test could be failing: dial_back_to_not_supporting, it's when alice and bob is trying to connect to each other inside bootstrap().await.

AFAIU: The test was supposed to check if we can dail back to the same host which is sending the request.

[elenaf9]

Can someone give me few pointer about why the test could be failing: dial_back_to_not_supporting, it's when alice and bob is trying to connect to each other inside bootstrap().await.

AFAIU: The test was supposed to check if we can dail back to the same host which is sending the request.

Do you have some logs when running it with DEBUG logging? Looking through the code I didn't find something obvious.

I think it's because you didn't include the obtained peer-id in case of a the PendingOutboundConnectionError when WrongPeerId, which resulted in the test's match statement not being fulfilled.

[akaladarshi]

I tried the changes as per your suggestion, but the tests are still failing, anyways thanks @elenaf9 for the review and the pointers, will try to fix them ASAP.

[elenaf9]

Also missing a major minor version bump of libp2p-swarm and a changelog entry 🙂

[akaladarshi]

Also missing a major version bump of libp2p-swarm and a changelog entry 🙂

Thanks 🙏, I wasn't not sure which version to bump to.

Edit: @elenaf9 Just to clarify major version would be 1.0.0 ?

[elenaf9]

Two last nits, rest LGTM. Thanks for the follow ups @akaladarshi!

[elenaf9]

LGTM!