Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(libp2p): arch gates *-websys export and dependencies. #5891

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat(libp2p): arch gates *-websys export and dependencies. #5891

wants to merge 4 commits into from
+15 −9

Conversation

elijahhampton
Copy link

@elijahhampton elijahhampton commented Feb 25, 2025 •
edited by dariusc93
Loading

Description

This merge request architecture gates *-websys dependencies to wasm in Cargo.toml and does similar arch gating in lib.rs for rexports of *-websys targets.

Closes #5885

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • [N/A] I have made corresponding changes to the documentation
  • [N/A] I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

dariusc93
dariusc93 reviewed Feb 25, 2025
View reviewed changes
Copy link
Member

@dariusc93 dariusc93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left one minor suggestion

@elijahhampton elijahhampton changed the title Arch gates -websys export targets in lib.rs. Arch gates *-websys dependencies. chore: Arch gates -websys export targets in lib.rs. Arch gates *-websys dependencies. Feb 26, 2025
dariusc93
dariusc93 reviewed Feb 26, 2025
View reviewed changes
Copy link
Member

@dariusc93 dariusc93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you bump the patch version? :)

@dariusc93 dariusc93 changed the title chore: Arch gates -websys export targets in lib.rs. Arch gates *-websys dependencies. chore: arch gates *-websys export and dependencies. Feb 26, 2025
dariusc93
dariusc93 reviewed Feb 26, 2025
View reviewed changes
Copy link
Member

@dariusc93 dariusc93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Can you update the Cargo.lock as well?

@dariusc93 dariusc93 requested a review from elenaf9 February 26, 2025 03:57
@elenaf9
Copy link
Contributor

elenaf9 commented Feb 26, 2025

Thanks! Can you bump the patch version? :)

Actually, I don't think the version bump was needed. libp2p-v0.55.1 isn't released yet.

@elenaf9 elenaf9 changed the title chore: arch gates *-websys export and dependencies. feat(libp2p): arch gates *-websys export and dependencies. Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariusc93 dariusc93 dariusc93 approved these changes

@elenaf9 elenaf9 Awaiting requested review from elenaf9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

libp2p: rexport *-websys transports only on wasm targets
3 participants
@elijahhampton @elenaf9 @dariusc93