feat(.github/add-new-impl): reference metrics dashboard #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference the perf dashboard, linking to the branch of the pull request, i.e. perf: https://observablehq.com/@libp2p-workspace/performance-dashboard?branch=perf%2Fgo-libp2p#branch
| @@ -65,7 +65,7 @@ jobs: | |||
| git push origin $BRANCH --force | |||
| # create a PR if an open one doesn't exist yet | |||
| if [[ $(gh pr list --state open --base $GITHUB_REF --head $BRANCH | wc -l) -eq 0 ]]; then | |||
| gh pr create --title "chore: add go-libp2p@$REMOTE_VERSION to $DIR" --body "This PR adds go-libp2p@$REMOTE_VERSION to $DIR" --head $BRANCH --base $GITHUB_REF | |||
| gh pr create --title "chore: add go-libp2p@$REMOTE_VERSION to $DIR" --body "This PR adds go-libp2p@$REMOTE_VERSION to $DIR\nSee new metrics at https://observablehq.com/@libp2p-workspace/performance-dashboard?branch=perf%2Fgo-libp2p#branch once \"perf: update benchmark results\" commit is pushed." --head $BRANCH --base $GITHUB_REF | |||
There was a problem hiding this comment.
This always references the branch branch, or am I misunderstanding the link?
There was a problem hiding this comment.
How about we create a comment on a PR (if it exists) when we push the commit (in the perf job itself)? That way we could reference the exact SHA of the commit and the link would keep working after the branch is merged & deleted. I can put a proposal for that in a sec.
There was a problem hiding this comment.
That's what I had in mind - https://github.com/libp2p/test-plans/pull/297/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference the perf dashboard, linking to the branch of the pull request, i.e. perf: https://observablehq.com/@libp2p-workspace/performance-dashboard?branch=perf%2Fgo-libp2p#branch