Run test plans on self-hosted GHA machines #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 30, 2022
Closed
laurentsenta
reviewed
Jan 3, 2023
| id: config | ||
| with: | ||
| script: | | ||
| if (`${context.repo.owner}/${context.repo.repo}` === 'libp2p/test-plans') { |
There was a problem hiding this comment.
That approach looks great. Do we need to take into account the fact that these jobs are used through reusable workflows?
https://docs.github.com/en/actions/using-workflows/reusing-workflows#using-github-hosted-runners
There was a problem hiding this comment.
If I understand the docs correctly, the context here will reference the caller repo which is exactly what we want. So if we call the reusable workflow from libp2p/test-plans, then we're going to use self-hosted runners. Otherwise, we'll fall back to the gh hosted ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves GHA workflows that are defined in this repository to self-hosted runners. The runners definition can be found here: https://github.com/pl-strflt/tf-aws-gh-runner/blob/main/runners.tf#L28
Why?
To address issues with:
How?
Testing