Cloud eval preparation #1467
Open
Cloud eval preparation #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien4215
force-pushed
the
cloud-eval-progress
branch
from
8abeb7a to
a1ef755
Compare
julien4215
commented
Feb 20, 2025
| transitionDuration: Duration.zero, | ||
| popoverTransitionBuilder: (_, child) => child, | ||
| ); | ||
| if (eval is LocalEval) { |
There was a problem hiding this comment.
I think we should also display a popover when it is a cloud eval but I didn't find a good way to do it.
julien4215
force-pushed
the
cloud-eval-progress
branch
from
a1ef755 to
5e39800
Compare
- add websocket eval events in BroadcastAnalysisController - use ClientEval type instead of LocalEval in AnalysisCurrentNode and engine widgets - add doc comments and necessary properties to ClientEval - edit engine depth widget to display a cloud icon when it is a cloud eval
julien4215
force-pushed
the
cloud-eval-progress
branch
from
5e39800 to
43a7614
Compare
|
This is tricky. Will review this thoroughly next week. |
|
Also this code is already complex, and with cloud eval will become even more. We need to add tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare cloud eval implementation :