Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding deeplinks #1477

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Adding deeplinks #1477

wants to merge 8 commits into from

Conversation

ItsDang
Copy link
Contributor

@ItsDang ItsDang commented Feb 22, 2025

Adding android deeplinks, basing list mainly off of v1

Link v1 v2
@/user ✔️
analysis ✔️
editor ✔️ ✔️
editor/fen ✔️ ✔️
editor/fen?color
challenge
inbox ✔️
player ✔️ ✔️
tournament ✔️
tv ✔️ ✔️
tv/channel ✔️
signup/confirm
Below Already implemented in main in v2
study ✔️ ✔️
training ✔️ ✔️
broadcast ✔️
game ✔️ ✔️

@veloce
Copy link
Contributor

veloce commented Feb 22, 2025

Thanks for making this useful comparison table.

About the PR, sorry but I'm putting deep links on hold for now. We shipped a few already and it has caused problems.

We'll not handle them the same way as in the old app. I think we'll be very conservative in regard to deep links in the new one.

@ItsDang
Copy link
Contributor Author

ItsDang commented Feb 22, 2025

For documentation, would you prefer me to leave this as a draft pr or issue or neither?

@veloce
Copy link
Contributor

veloce commented Feb 24, 2025

We can close this and refer to it later for documentation. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants