Add PhaseShift Transform #1714
Merged
Add PhaseShift Transform #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1714 +/- ##
==========================================
+ Coverage 84.88% 84.93% +0.05%
==========================================
Files 157 158 +1
Lines 6543 6567 +24
==========================================
+ Hits 5554 5578 +24
Misses 989 989 ☔ View full report in Codecov by Sentry. |
guarin
reviewed
Nov 1, 2024
There was a problem hiding this comment.
This looks great, thanks so much for the PR!
I have one concern regarding the dimension of theta.
Could you also upload some examples of transformed images? Then it is easier to verify that the implementation is correct. The images should look like this according to the paper:
guarin
requested changes
Nov 5, 2024
Co-authored-by: guarin <[email protected]>
Co-authored-by: guarin <[email protected]>
Co-authored-by: guarin <[email protected]>
guarin
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1659
Modified file(s)
lightly/transforms/__init__.py: Added new transform imports for phase shift transform.gitignore: Added.venvto ignored packagesCreated file(s)
lightly/transforms/phase_shift_transform.pytests/transforms/test_phase_shift_transform.py