Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proof: add signed universe commitment params #1363

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

guggero
Copy link
Member

@guggero guggero commented Feb 7, 2025

Depends on #1335, only last commit is new.

Adds a new struct that contains the universe commitment parameters and a signature over it.

TODOs:

  • Allow commitment params to have unknown odd records
  • Add the struct to the main Proof type

@coveralls
Copy link

coveralls commented Feb 7, 2025

Pull Request Test Coverage Report for Build 13412695300

Details

  • 151 of 206 (73.3%) changed or added relevant lines in 2 files are covered.
  • 34 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.07%) to 54.527%

Changes Missing Coverage Covered Lines Changed/Added Lines %
proof/encoding.go 32 44 72.73%
proof/uni_commitments.go 119 162 73.46%
Files with Coverage Reduction New Missed Lines %
commitment/tap.go 1 85.0%
asset/group_key.go 2 72.65%
tapgarden/custodian.go 2 75.27%
rfqmsg/records.go 3 71.2%
universe/base.go 3 79.25%
tapchannel/aux_leaf_signer.go 5 43.08%
address/mock.go 18 86.93%
Totals Coverage Status
Change from base Build 13397714787: 0.07%
Covered Lines: 48794
Relevant Lines: 89486

💛 - Coveralls

@guggero guggero force-pushed the universe-commitments-proof branch from df2a398 to a132dea Compare February 19, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

2 participants