Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wallet 3/3]: group key support for channel funding #1413

Draft
wants to merge 4 commits into
base: allocation-refactor
Choose a base branch
from

Conversation

guggero
Copy link
Member

@guggero guggero commented Feb 26, 2025

Adds the ability to fund multiple tranches of a grouped asset into a channel.

TODO:

  • Update channel closer code
  • Update sweeper code
  • Extend itest with coop and force close test cases

Corresponding itest: lightninglabs/lightning-terminal#987

Part of the group key support saga:

@coveralls
Copy link

coveralls commented Feb 26, 2025

Pull Request Test Coverage Report for Build 13571552700

Details

  • 14 of 93 (15.05%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on group-key-support at 54.566%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rpcserver.go 0 1 0.0%
tapchannelmsg/custom_channel_data.go 0 2 0.0%
tapdb/assets_store.go 4 7 57.14%
taprpc/tapchannelrpc/tapchannel.pb.go 0 5 0.0%
tapchannel/aux_funding_controller.go 0 68 0.0%
Totals Coverage Status
Change from base Build 13571552842: 54.6%
Covered Lines: 49008
Relevant Lines: 89814

💛 - Coveralls

This was kind of correct for a single asset tranche in a channel. But
for multiple tranches, we need to calculate the sum correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

2 participants