Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Symfony 6 #160

Merged
merged 5 commits into from
Nov 30, 2021
Merged

Allow Symfony 6 #160

merged 5 commits into from
Nov 30, 2021

Conversation

alexislefebvre
Copy link
Collaborator

@alexislefebvre alexislefebvre commented Nov 22, 2021

When PHP 8.1 will be released and available on CI, and when Symfony 6 will be released:

@alexislefebvre alexislefebvre marked this pull request as draft November 22, 2021 20:00
@alexislefebvre alexislefebvre self-assigned this Nov 22, 2021
@alexislefebvre alexislefebvre marked this pull request as ready for review November 22, 2021 22:02
@alexislefebvre alexislefebvre marked this pull request as draft November 22, 2021 22:02
@alexislefebvre alexislefebvre force-pushed the allow-symfony-6 branch 2 times, most recently from d4db3bc to f3d1c0c Compare November 26, 2021 12:44
@alexislefebvre
Copy link
Collaborator Author

Tests are broken because the calls to self::$container don't work with Symfony 6, it was deprecated then removed:

    /**
     * @var ContainerInterface
     *
     * @deprecated since Symfony 5.3, use static::getContainer() instead
     */
    protected static $container;

We have to see if getContainer() exist in Symfony 4.

@alexislefebvre alexislefebvre marked this pull request as ready for review November 30, 2021 21:15
@alexislefebvre alexislefebvre merged commit 87e1f44 into liip:2.x Nov 30, 2021
@alexislefebvre alexislefebvre deleted the allow-symfony-6 branch November 30, 2021 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant