Ensure PathEncoder encodes in little-endian
#820
Draft
+58
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already assume these are word-aligned, and so this would catch a failure of that assumption much earller. A future change would be to encode the full scene encoding as u32. That would be useful for #810, as the current code has an alignment hazard
(On top of #817 to prevent conflicts.) WGSL expects little-endian data, but Vello currently doesn't convert to little-endian, except for colors: `DrawColor` specifies its endianness explicitly, with conversion handled by the Color crate. On big-endian hosts, the other encodings would break. Whether big-endian hosts are a valid target for Vello, I do not know. This is opened in part as a place to have that discussion. If this is desirable, other places will need attention. I have not taken a look yet.
|
Consider all the structs with |
|
I think that it would be good to get this right, but it's hard because of the CPU shaders; the CPU shaders need to have the opposite transformation. My preference (as we discussed yesterday) would be to just fail to compile for a big endian system (and adding a non-feature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(On top of #817 to prevent conflicts. See 6c4d4cc for the changes here.)
WGSL expects little-endian data, but Vello currently doesn't convert to little-endian, except for colors:
DrawColorspecifies its endianness explicitly, with conversion handled by the Color crate. On big-endian hosts, the other encodings would break.Whether big-endian hosts are a valid target for Vello, I do not know. This is opened in part as a place to have that discussion. If this is desirable, other places will need attention. I have not taken a look yet.