-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support ph and explicit labels in t and Trans #139
Conversation
I noticed there are quite a lot of code style inconsistencies so I had to use "save without formatting" every time. Do you not use rustfmt? |
Unfortunately, i was planned to do after merging v5 branch, to avoid merge conflicts. But then, switched to something else. Would you like to apply rustfmt and create a separate PR with it? Would also be nice to implement rustfmt check on the github workflow to reject PR's which is not formatted properly. I'm afraid if i will do that myself i'll bring merge conflicts to your branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original implementation also supports ph()
method imported from lingui macro, do you want to implement support for that in this PR?
Yes, sorry. I forgot to mention that I'll add it to this PR soon. |
you can start review, but I want to also add tests for jsx choice components later |
@KubaJastrz thanks for your help! I pushed some minor fixes and merged this to main branch. |
first attempt at migrating lingui/js-lingui#2092 to swc plugin