Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ph and explicit labels in t and Trans #139

Merged
merged 7 commits into from
Feb 17, 2025

Conversation

KubaJastrz
Copy link
Contributor

first attempt at migrating lingui/js-lingui#2092 to swc plugin

@KubaJastrz
Copy link
Contributor Author

I noticed there are quite a lot of code style inconsistencies so I had to use "save without formatting" every time. Do you not use rustfmt?

@timofei-iatsenko
Copy link
Collaborator

I noticed there are quite a lot of code style inconsistencies so I had to use "save without formatting" every time. Do you not use rustfmt?

Unfortunately, i was planned to do after merging v5 branch, to avoid merge conflicts. But then, switched to something else. Would you like to apply rustfmt and create a separate PR with it? Would also be nice to implement rustfmt check on the github workflow to reject PR's which is not formatted properly.

I'm afraid if i will do that myself i'll bring merge conflicts to your branch.

Copy link
Collaborator

@timofei-iatsenko timofei-iatsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original implementation also supports ph() method imported from lingui macro, do you want to implement support for that in this PR?

@KubaJastrz
Copy link
Contributor Author

ph

Yes, sorry. I forgot to mention that I'll add it to this PR soon.

@KubaJastrz KubaJastrz changed the title feat: support explicit labels in t and Trans feat: support ph and explicit labels in t and Trans Feb 9, 2025
@KubaJastrz
Copy link
Contributor Author

you can start review, but I want to also add tests for jsx choice components later

@timofei-iatsenko timofei-iatsenko merged commit f80ed19 into lingui:main Feb 17, 2025
3 checks passed
@timofei-iatsenko
Copy link
Collaborator

@KubaJastrz thanks for your help! I pushed some minor fixes and merged this to main branch.

@KubaJastrz KubaJastrz deleted the explict-labels branch February 17, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants