Upgrade swc_core to v13.3.0 #144
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hain@v1 action and defer to rust-toolchain.toml for targets, etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we upgrade the
swc_corecrate to v13.3.0. This makes the plugin compatible with v1.2.3 and 1.2.4 of Rspack which will allow projects using this plugin to upgrade.A few things of note:
swc_core. The major changes are documented at the top of this page: https://swc.rs/docs/plugin/ecmascript/getting-startedactions-rust-lang/setup-rust-toolchain@v1which is a newer, more advanced version of the action this project was already using. It will respect the values inrust-toolchain.tomlreducing how many times the toolchain needs to be specifiedLinguiMacroFolderneeded to be wrapped infold_pass()calls in tests to be compatible with the new parameter list thattest_inline!expects.Once these changes were complete, all tests passed and I was able to install this plugin in a real project that uses Rspack and build it successfully.