Add Client (VX-83) #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sufuf3
commented
Jun 5, 2018
sufuf3
commented
- FindNetworkNamespacePath
- ConnectBridge
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
=======================================
Coverage 84.53% 84.53%
=======================================
Files 7 7
Lines 181 181
=======================================
Hits 153 153
Misses 19 19
Partials 9 9Continue to review full report at Codecov.
|
hwchiu
suggested changes
Jun 5, 2018
John-Lin
reviewed
Jun 5, 2018
client/main.go
Outdated
| if err != nil { | ||
| log.Fatalf("There is something wrong with find network namespace pathpart.\n %v", err) | ||
| } | ||
| if n.Success == true { |
There was a problem hiding this comment.
Could use
if n.Success {
...
}
sufuf3
force-pushed
the
sufuf3/client
branch
2 times, most recently
from
febbba4 to
45f7a6a
Compare
|
Rebase |
|
我先暫時用我自己的 docker hub 跟這個 repo 連結，來自動 build docker image. |
- Update client code to deal with multi-veth and change to socket - Add k8s pod yaml for testing - Add init container dockerfile with network controller client binary file - Update server from tcp to unix domain socket
…nd we want to use
- Remove unused makefile target - Exit the clinet if the gRCP call fail
John-Lin
approved these changes
Jun 11, 2018
chenyunchen
approved these changes
Jun 11, 2018
chenyunchen
approved these changes
Jun 11, 2018
hwchiu
approved these changes
Jun 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.