Add configureiface - VX-84 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
=========================================
+ Coverage 79.67% 81.5% +1.83%
=========================================
Files 5 5
Lines 123 146 +23
=========================================
+ Hits 98 119 +21
- Misses 18 20 +2
Partials 7 7
Continue to review full report at Codecov.
|
chenyunchen
force-pushed
the
alex/addconfigureIface
branch
from
c039348 to
b47c515
Compare
hwchiu
suggested changes
Jun 5, 2018
messages/messages.proto
Outdated
| message ConfigureIfaceRequest { | ||
| string IP = 1; | ||
| string gateway = 2; | ||
| string route = 3; |
There was a problem hiding this comment.
Remove the route and use the gateway is enough.
chenyunchen
force-pushed
the
alex/addconfigureIface
branch
2 times, most recently
from
e1bde6b to
b16c19f
Compare
John-Lin
approved these changes
Jun 5, 2018
chenyunchen
force-pushed
the
alex/addconfigureIface
branch
from
b16c19f to
98b1ebb
Compare
hwchiu
approved these changes
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.