Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VX-84 Add port statistics #26

Merged
merged 2 commits into from
Jun 9, 2018
Merged

VX-84 Add port statistics #26

merged 2 commits into from
Jun 9, 2018

Conversation

chenyunchen
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jun 7, 2018

Codecov Report

Merging #26 into master will increase coverage by 1.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   85.03%   86.13%   +1.09%     
==========================================
  Files           5        5              
  Lines         127      137      +10     
==========================================
+ Hits          108      118      +10     
  Misses         12       12              
  Partials        7        7
Impacted Files Coverage Δ
openvswitch/ovs.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d7d3ce...0a2521f. Read the comment docs.

@hwchiu hwchiu self-requested a review June 7, 2018 04:58
Copy link
Contributor

@hwchiu hwchiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the testing to make sure the code coverage > 80%

@chenyunchen chenyunchen force-pushed the alex/AddPortStatistics branch from da7f7c6 to 77969c3 Compare June 7, 2018 05:45
@chenyunchen chenyunchen force-pushed the alex/AddPortStatistics branch from 77969c3 to 87a0ac0 Compare June 7, 2018 06:00
@chenyunchen chenyunchen force-pushed the alex/AddPortStatistics branch 4 times, most recently from 9df3738 to 13bd746 Compare June 8, 2018 09:08
@chenyunchen chenyunchen force-pushed the alex/AddPortStatistics branch from 13bd746 to 0a2521f Compare June 8, 2018 09:08
@John-Lin
Copy link
Contributor

John-Lin commented Jun 9, 2018

LGTM

@John-Lin John-Lin merged commit 8939b35 into master Jun 9, 2018
@hwchiu hwchiu deleted the alex/AddPortStatistics branch June 11, 2018 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants