Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing #3

Merged
merged 3 commits into from
Jun 2, 2018
Merged

Add testing #3

merged 3 commits into from
Jun 2, 2018

Conversation

hwchiu
Copy link
Contributor

@hwchiu hwchiu commented May 31, 2018

  • Add more testing
  • Use the ip link to create virtual NIC for add/del port
  • Change the file permission to testing the add bridge fail.

@codecov-io
Copy link

codecov-io commented May 31, 2018

Codecov Report

Merging #3 into master will increase coverage by 80%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #3    +/-   ##
======================================
+ Coverage      20%   100%   +80%     
======================================
  Files           1      1            
  Lines          15     15            
======================================
+ Hits            3     15    +12     
+ Misses         11      0    -11     
+ Partials        1      0     -1
Impacted Files Coverage Δ
ovs/ovs.go 100% <0%> (+80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ac2cee...78361c6. Read the comment docs.

@hwchiu hwchiu force-pushed the hwchiu/add-test branch from 43a7583 to 2a8f1e4 Compare May 31, 2018 10:26
@hwchiu hwchiu requested a review from chenyunchen June 1, 2018 06:16
@John-Lin John-Lin merged commit 4e7b84b into master Jun 2, 2018
@hwchiu hwchiu deleted the hwchiu/add-test branch June 4, 2018 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants