Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add docker-ce #33

Merged
merged 1 commit into from
Jun 12, 2018
Merged

add docker-ce #33

merged 1 commit into from
Jun 12, 2018

Conversation

John-Lin
Copy link
Contributor

@John-Lin John-Lin commented Jun 11, 2018 •
edited
Loading

fixed #28

@John-Lin John-Lin requested review from hwchiu and chenyunchen June 11, 2018 15:59
@codecov
Copy link

codecov bot commented Jun 11, 2018 •
edited
Loading

Codecov Report

Merging #33 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #33   +/-   ##
=======================================
  Coverage   86.44%   86.44%           
=======================================
  Files           7        7           
  Lines         177      177           
=======================================
  Hits          153      153           
  Misses         15       15           
  Partials        9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8e484c...a74608a. Read the comment docs.

hwchiu
hwchiu approved these changes Jun 12, 2018
View reviewed changes
Copy link
Contributor

@hwchiu hwchiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hwchiu hwchiu merged commit ff044c9 into master Jun 12, 2018
@John-Lin John-Lin deleted the johnlin/vagrant-docker-ce branch June 12, 2018 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwchiu hwchiu hwchiu approved these changes

@chenyunchen chenyunchen chenyunchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the vagrantfile support docker-ce
3 participants
@John-Lin @hwchiu @chenyunchen