Add the deployment yaml files for client/server #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hwchiu
commented
Jun 12, 2018
hwchiu
commented
- use the shard for /run (for netns/docker.sock/ovsdb.sock)
- fix the image
- fix the command and args
- add the log in server/client
- install sudo in dockerfile for ovs-vsctl
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
=======================================
Coverage 86.81% 86.81%
=======================================
Files 7 7
Lines 182 182
=======================================
Hits 158 158
Misses 15 15
Partials 9 9Continue to review full report at Codecov.
|
John-Lin
suggested changes
Jun 12, 2018
deploy/server/unix-daemonset.yaml
Outdated
| - mountPath: /tmp/ | ||
| name: grpc-sock | ||
| volumes: | ||
| - name: docker-sock | ||
| hostPath: | ||
| path: /var/run/docker.sock | ||
| path: /run |
added 2 commits
June 12, 2018 04:35
1. use the shard for /run (for netns/docker.sock/ovsdb.sock) 2. fix the image 3. fix the command and args 4. add the log in server/client 5. install sudo in dockerfile for ovs-vsctl
|
@sufuf3 @chenyunchen |
John-Lin
approved these changes
Jun 12, 2018
chenyunchen
approved these changes
Jun 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.