Add port tag or vlan,trunk options setting #51
Conversation
messages/messages.proto
Outdated
| @@ -55,6 +57,28 @@ message AddPortRequest { | |||
| string ifaceName = 2; | |||
| } | |||
|
|
|||
| message PortOptions { | |||
| int32 tag = 1; | |||
messages/messages.proto
Outdated
|
|
||
| message SetPortRequest { | ||
| string ifaceName = 1; | ||
| PortOptions portOptions = 2; |
There was a problem hiding this comment.
you are in the PortRequest, you don't have to prefix it.
server/openvswitch_handler.go
Outdated
| } | ||
| for _, t := range portOptions.Trunk { | ||
| options.Trunk = append(options.Trunk, int32(t)) | ||
| } |
There was a problem hiding this comment.
if there is a reason, could you please add a comment for it? thank you~
There was a problem hiding this comment.
convert for grpc message response (int to int32)
| "revision": "eab982908a30d98500ba243e022247947d9ca570", | ||
| "revisionTime": "2018-06-28T03:23:49Z" | ||
| "revision": "614ef75bf4e8c6de85a736c9086f628a049011ec", | ||
| "revisionTime": "2018-06-28T09:23:35Z" |
There was a problem hiding this comment.
would be good to have a separated PR for updating the dependency. If the purpose is different. :-)
There was a problem hiding this comment.
It's for the same purpose. Fix the command output bug on go-openvswitch package for network-controller to use.
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
=========================================
+ Coverage 84.4% 86.91% +2.5%
=========================================
Files 7 7
Lines 186 191 +5
=========================================
+ Hits 157 166 +9
+ Misses 18 16 -2
+ Partials 11 9 -2
Continue to review full report at Codecov.
|
chenyunchen
force-pushed
the
alex/AddPortVLANTrunkSetting
branch
4 times, most recently
from
6d6b306 to
2d1dc60
Compare
No description provided.