add go vet to do static check #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
=======================================
Coverage 80.82% 80.82%
=======================================
Files 3 3
Lines 73 73
=======================================
Hits 59 59
Misses 12 12
Partials 2 2Continue to review full report at Codecov.
|
John-Lin
force-pushed
the
johnlin/vet-static-check
branch
2 times, most recently
from
623cb95 to
989653a
Compare
hwchiu
reviewed
Jun 2, 2018
Makefile
Outdated
| @@ -31,12 +32,18 @@ client: | |||
| go build ${LDFLAGS} -o ${BINARY}-client . ; \ | |||
| cd - >/dev/null | |||
|
|
|||
| vet: | |||
| -cd ${BUILD_DIR}; \ | |||
There was a problem hiding this comment.
Since we are in the project, why we need to cd again ?
We usually call the Makefile ... in the same directory
And the -cd is typo ?
John-Lin
force-pushed
the
johnlin/vet-static-check
branch
from
989653a to
d44828c
Compare
John-Lin
force-pushed
the
johnlin/vet-static-check
branch
from
d44828c to
0798410
Compare
hwchiu
approved these changes
Jun 3, 2018
chenyunchen
approved these changes
Jun 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add go vet to do static check