Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more testing #8

Merged
merged 7 commits into from
Jun 3, 2018
Merged

Add more testing #8

merged 7 commits into from
Jun 3, 2018

Conversation

hwchiu
Copy link
Contributor

@hwchiu hwchiu commented Jun 2, 2018

  • Add the testing for gRPC
  • Add the testing for invalid FindK8SPauseContainerIDFail case

@hwchiu hwchiu requested review from John-Lin and chenyunchen June 2, 2018 17:16
@hwchiu hwchiu force-pushed the hwchiu/add-more-test branch from be57002 to 53359d7 Compare June 2, 2018 17:18
@codecov
Copy link

codecov bot commented Jun 2, 2018

Codecov Report

Merging #8 into master will increase coverage by 20.54%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #8       +/-   ##
===========================================
+ Coverage   60.27%   80.82%   +20.54%     
===========================================
  Files           3        3               
  Lines          73       73               
===========================================
+ Hits           44       59       +15     
+ Misses         23       12       -11     
+ Partials        6        2        -4
Impacted Files Coverage Δ
openvswitch/ovs.go 92.3% <100%> (+23.07%) ⬆️
docker/pause-container.go 100% <0%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1df18b...40f92f5. Read the comment docs.

@John-Lin John-Lin merged commit 54d8b65 into master Jun 3, 2018
@hwchiu hwchiu deleted the hwchiu/add-more-test branch June 4, 2018 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants