Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] client support add route via interface and via gateway ip #80

Merged
merged 4 commits into from
Aug 16, 2018
Merged

[Task] client support add route via interface and via gateway ip #80

merged 4 commits into from
Aug 16, 2018

Conversation

John-Lin
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 16, 2018 •
edited
Loading

Codecov Report

Merging #80 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #80   +/-   ##
=======================================
  Coverage   88.31%   88.31%           
=======================================
  Files           7        7           
  Lines         214      214           
=======================================
  Hits          189      189           
  Misses         16       16           
  Partials        9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8b007b...56e8ff6. Read the comment docs.

@John-Lin
Copy link
Contributor Author

John-Lin commented Aug 16, 2018 •
edited
Loading 

/ # ifconfig
eth0      Link encap:Ethernet  HWaddr 0A:58:0A:F4:00:12
          inet addr:10.244.0.18  Bcast:0.0.0.0  Mask:255.255.255.0
          UP BROADCAST RUNNING MULTICAST  MTU:1450  Metric:1
          RX packets:17 errors:0 dropped:0 overruns:0 frame:0
          TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:0
          RX bytes:1122 (1.0 KiB)  TX bytes:0 (0.0 B)

eth100    Link encap:Ethernet  HWaddr 5A:5F:DD:E5:7C:64
          inet addr:192.168.24.50  Bcast:192.168.24.255  Mask:255.255.255.0
          UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
          RX packets:8 errors:0 dropped:0 overruns:0 frame:0
          TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:0
          RX bytes:648 (648.0 B)  TX bytes:0 (0.0 B)

lo        Link encap:Local Loopback
          inet addr:127.0.0.1  Mask:255.0.0.0
          UP LOOPBACK RUNNING  MTU:65536  Metric:1
          RX packets:0 errors:0 dropped:0 overruns:0 frame:0
          TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:1
          RX bytes:0 (0.0 B)  TX bytes:0 (0.0 B)

/ # route -n
Kernel IP routing table
Destination     Gateway         Genmask         Flags Metric Ref    Use Iface
0.0.0.0         10.244.0.1      0.0.0.0         UG    0      0        0 eth0
10.244.0.0      0.0.0.0         255.255.255.0   U     0      0        0 eth0
10.244.0.0      10.244.0.1      255.255.0.0     UG    0      0        0 eth0
192.168.24.0    0.0.0.0         255.255.255.0   U     0      0        0 eth100
192.168.88.0    0.0.0.0         255.255.255.0   U     0      0        0 eth100

@John-Lin John-Lin requested review from hwchiu and sufuf3 August 16, 2018 10:11
sufuf3
sufuf3 reviewed Aug 16, 2018
View reviewed changes
README.md Outdated
and server will remove that file when server is been terminated
The network-controller server provide two ways to listen, TCP and Unix domain socket
If you want to run as a UNIX domain socket server, you should specify a path to store the sock file
and server will remove that file when server is been terminated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

兩格空白在每一行後面會斷行，在 markdown 中，這三行會變成一行的句子。
要不然，就要加 . 了。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok 那我調整一下排版，如果沒有太大問題先合併之後可以再整理README

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use Vq in vim

@John-Lin John-Lin mentioned this pull request Aug 16, 2018
Closed
@John-Lin
Copy link
Contributor Author

this fixed #40

@John-Lin John-Lin merged commit 948d2a4 into master Aug 16, 2018
@John-Lin John-Lin deleted the johnlin/client-addroute branch August 16, 2018 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c9s c9s c9s approved these changes

@sufuf3 sufuf3 sufuf3 left review comments

@hwchiu hwchiu Awaiting requested review from hwchiu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@John-Lin @c9s @sufuf3