Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VX-49 Add Interrupt Signal #9

Merged
merged 1 commit into from
Jun 3, 2018
Merged

VX-49 Add Interrupt Signal #9

merged 1 commit into from
Jun 3, 2018

Conversation

chenyunchen
Copy link
Contributor

When catching interrupt signal, stop the TCP listener and grpc server.

@chenyunchen chenyunchen force-pushed the alex/addInterruptSignal branch from ee3acf8 to 8c8b94f Compare June 3, 2018 08:42
@codecov
Copy link

codecov bot commented Jun 3, 2018

Codecov Report

Merging #9 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #9   +/-   ##
=======================================
  Coverage   80.82%   80.82%           
=======================================
  Files           3        3           
  Lines          73       73           
=======================================
  Hits           59       59           
  Misses         12       12           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54d8b65...8c8b94f. Read the comment docs.

@John-Lin John-Lin self-requested a review June 3, 2018 10:34
Copy link
Contributor

@hwchiu hwchiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hwchiu hwchiu merged commit cd25171 into master Jun 3, 2018
@hwchiu hwchiu deleted the alex/addInterruptSignal branch June 3, 2018 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants