[Task] VX-272: Use table to list the nodes. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenyunchen
reviewed
Aug 20, 2018
src/routes/Cluster/Node/index.tsx
Outdated
| numerator.toString() + | ||
| ' (' + | ||
| ((numerator / denominator) * 100).toFixed(2).toString() + | ||
| '%)' |
There was a problem hiding this comment.
`${numerator.toString()} (${((numerator / denominator) * 100).toFixed(2).toString()}%)`
chenyunchen
reviewed
Aug 20, 2018
src/routes/Cluster/Node/index.tsx
Outdated
| ), | ||
| age: moment( | ||
| new Date(this.props.nodes[node].detail.createAt * 1000) | ||
| ).fromNow() |
There was a problem hiding this comment.
moment(this.props.nodes[node].detail.createAt * 1000).fromNow()
chenyunchen
reviewed
Aug 20, 2018
src/routes/Cluster/Node/index.tsx
Outdated
| ((numerator / denominator) * 100).toFixed(2).toString() + | ||
| '%)' | ||
| ); | ||
| }; |
There was a problem hiding this comment.
`${formatBytes(numerator)} (${((numerator / denominator) * 100).toFixed(2).toString()}%)`
LucienLee
reviewed
Aug 20, 2018
LucienLee
reviewed
Aug 20, 2018
src/routes/Cluster/Node/index.tsx
Outdated
| <Row> | ||
| <Col span={12}> | ||
| {this.renderListItemContent( | ||
| <FormattedMessage id={`node.detail.createdAt`} />, |
There was a problem hiding this comment.
if you don't have concat variable, just use plan single quote rather than literal template.
There was a problem hiding this comment.
and also could remove bracket.
WakeupTsai
force-pushed
the
phstsai/VX-272
branch
from
f645ace to
df3a67b
Compare
WakeupTsai
force-pushed
the
phstsai/VX-272
branch
from
df3a67b to
3818699
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.