[Task] Pop notification when creating or deleting resources #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucienLee
suggested changes
Sep 7, 2018
| @@ -71,6 +71,10 @@ class CreateDeployment extends React.Component< | |||
| protected handleSubmit = (deployment: DeploymentModel.Deployment) => { | |||
| this.props.addDeployment(deployment); | |||
| this.props.push('/application/deployment'); | |||
| return notification.success({ | |||
| } | ||
| }; | ||
|
|
||
| protected handleRemoveDeployment = (id: string) => { | ||
| this.setState({ deletable: false }); | ||
| this.props.removeDeployment(id); | ||
| clearInterval(this.intervalPodId); | ||
| return notification.success({ |
| return <Icon type="clock-circle" className={styles.pendIcon} />; | ||
| default: | ||
| return <Icon type="close-circle" className={styles.errorIcon} />; | ||
| protected renderStatusIcon = (deployment: DeploymentModel.Controller) => { |
There was a problem hiding this comment.
// Nice to have
const isPending = deployment.currentPod === deployment.desiredPod;
const isRunning = deployment.currentPod === deployment.availablePod;
const classname = isPending
? ( isRunning ? styles.readyIcon : styles.pending )
: styles.errorIcon
return ;
| @@ -50,14 +50,26 @@ class Namespace extends React.Component<NamespaceProps, NamespaceState> { | |||
| protected handleSubmit = (namespace: NamespaceModel.Namespace) => { | |||
| this.props.addNamespace(namespace); | |||
| this.setState({ visibleModal: false }); | |||
| return notification.success({ | |||
| @@ -50,14 +50,26 @@ class Namespace extends React.Component<NamespaceProps, NamespaceState> { | |||
| protected handleSubmit = (namespace: NamespaceModel.Namespace) => { | |||
| this.props.addNamespace(namespace); | |||
| this.setState({ visibleModal: false }); | |||
| return notification.success({ | |||
| message: 'Success', | |||
| description: 'Create the namespace successfully.' | |||
There was a problem hiding this comment.
have to put into i18n. You can look what I did in another files.
WakeupTsai
force-pushed
the
phstsai/notification
branch
from
b643e7d to
93e5bc3
Compare
LucienLee
reviewed
Sep 13, 2018
src/components/PodDrawer/index.tsx
Outdated
| @@ -182,7 +182,7 @@ class PodDrawer extends React.PureComponent<PodDrawerProps, PodDrawerState> { | |||
| protected handleRemovePod = (id: string) => { | |||
| this.setState({ deletable: false }); | |||
| this.props.removePod(id); | |||
| return notification.success({ | |||
| notification.success({ | |||
| message: 'Success', | |||
| description: 'Delete the pod successfully.' | |||
There was a problem hiding this comment.
please enable i18n on notification message.
WakeupTsai
force-pushed
the
phstsai/notification
branch
from
02e4ff4 to
c9c5a04
Compare
WakeupTsai
force-pushed
the
phstsai/notification
branch
from
8b9f1d4 to
21eb87f
Compare
LucienLee
approved these changes
Sep 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.