Update locales files #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sufuf3
reviewed
Sep 7, 2018
src/locales/en-US/network.js
Outdated
| @@ -28,5 +24,5 @@ export default { | |||
| 'network.hint.uniqueName': '{name} has been used! Try a new name.', | |||
| 'network.hint.selectNode': 'Select a node', | |||
| 'network.hint.selectInterfaces': 'Select interfaces', | |||
| 'network.hint.VLANTag': 'Please enter a number between 0 ~ 4095.', | |||
| } | |||
| 'network.hint.vlanTags': 'Please enter a number between 0 ~ 4095.', | |||
There was a problem hiding this comment.
The whole name of VLAN is Virtual Local Area Network.
Not sure that convert VLAN to lower case is good?
What do you think?
Thanks.
There was a problem hiding this comment.
keep VLANTags and I have to put the missed s back to source code.
src/locales/en-US/service.js
Outdated
| 'service.type': 'type', | ||
| 'service.selectors': 'selectors', | ||
| 'service.ports': 'ports', | ||
| 'service.add': 'Add Service', | ||
| 'service.createdAt': 'created at', | ||
| 'service.add': 'add Service', |
There was a problem hiding this comment.
Add is verb. Maybe need to update to Add Service?
How do you like?
src/locales/en-US/volume.js
Outdated
| 'volume.storageName': 'storage name', | ||
| 'volume.accessMode': 'access mode', | ||
| 'volume.storageName': 'storage Name', | ||
| 'volume.accessMode': 'access Mode', |
There was a problem hiding this comment.
Let's use lowercase, according to this comment.
#33 (comment)
There was a problem hiding this comment.
keep as access mode, storage name
src/locales/zh-Hant/auth.js
Outdated
| 'auth.hint.signup.success': '註冊成功', | ||
| 'auth.hint.signup.success.description': 'Please sign in with your email and password', | ||
| 'auth.hint.signup.success.description': '請使你的帳號密碼來登入', |
src/locales/zh-Hant/auth.js
Outdated
| 'auth.hint.signin.failure': 'Failed to Signin', | ||
| 'auth.help.password': 'This is one-time password, please send to your user.' | ||
| 'auth.hint.signin.failure': '登入失敗', | ||
| 'auth.help.password': '此為一次性的密碼，請交給使用者。' |
src/locales/zh-Hant/hub.js
Outdated
| @@ -1,6 +1,6 @@ | |||
| export default { | |||
| 'hub.imageHub': '映像倉庫', | |||
| 'hub.login': 'Login to unlock private image registry', | |||
| 'hub.login': '登入以進入私有 Image 庫', | |||
There was a problem hiding this comment.
|
Tag 和 Label 要看上下文，我有點不確定我們這邊的 Tag 跟 Label 是用在哪裡？ |
|
1.映像檔標籤 |
|
vLAN tag的tag呢？ |
WakeupTsai
force-pushed
the
phstsai/update-zh
branch
from
3b24c45 to
c527db7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.