Merge pull request #107 from linkernetworks/johnlin/invalidIPforStorage

add test for invalid NFS IP Former-commit-id: 3bfb32cea4c9f60d28040e3facd37190295fa68c [formerly 3bfb32cea4c9f60d28040e3facd37190295fa68c [formerly f2d6de2]] Former-commit-id: 883f34123f3e81203b5633a41406ea94e2bf09f8 Former-commit-id: e36e2b1
linkernetworks · Jul 17, 2018 · 12edbbf · 12edbbf
2 parents ef1c9af + be71a4b
commit 12edbbf
Showing 1 changed file with 26 additions and 3 deletions.
diff --git a/src/server/handler_storage_test.go b/src/server/handler_storage_test.go
@@ -122,18 +122,41 @@ func (suite *StorageTestSuite) TestCreateStorageFail() {
 			Fake: &entity.FakeStorage{
 				FakeParameter: "Yo",
 				IWantFail:     true,
-			}},
+			},
+		},
 			http.StatusInternalServerError},
+		{"inValidNFSIP", entity.Storage{
+			Type:             entity.FakeStorageType,
+			Name:             namesgenerator.GetRandomName(1),
+			StorageClassName: namesgenerator.GetRandomName(0),
+			IP:               "256.256.256.256",
+			PATH:             "/myspace",
+			Fake: &entity.FakeStorage{
+				FakeParameter: "Yo",
+			},
+		},
+			http.StatusBadRequest},
+		{"lackStorageName", entity.Storage{
+			Type:             entity.FakeStorageType,
+			StorageClassName: namesgenerator.GetRandomName(0),
+			IP:               "256.256.256.256",
+			PATH:             "/myspace",
+			Fake: &entity.FakeStorage{
+				FakeParameter: "Yo",
+			},
+		},
+			http.StatusBadRequest},
 		{"StorageTypeError", entity.Storage{
 			Name:             namesgenerator.GetRandomName(0),
 			StorageClassName: namesgenerator.GetRandomName(1),
-			Type:             "non-exist",
+			Type:             "none-exist",
 			IP:               "192.168.5.100",
 			PATH:             "/myspace",
 			Fake: &entity.FakeStorage{
 				FakeParameter: "Yo",
 				IWantFail:     true,
-			}},
+			},
+		},
 			http.StatusBadRequest},
 	}