Skip to content

Commit

Permalink
Use k8s-config for clientset
Browse files Browse the repository at this point in the history
Former-commit-id: c8957c31485fc9ab3dd570c57d9a61c9ca1a2209 [formerly 00eddd5]
Former-commit-id: cda6a2d854dcd01c2e91fffa2b32ddc160577a0d
  • Loading branch information
chenyunchen committed Jun 21, 2018
1 parent 5504155 commit 14618ed
Show file tree
Hide file tree
Showing 7 changed files with 24 additions and 36 deletions.
1 change: 0 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ install:
- make pre-build

script:
- sudo -E env PATH=$$PATH TEST_K8S=1
- make build
- make test
- make src.test-coverage
Expand Down
5 changes: 1 addition & 4 deletions config/k8s.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,5 @@
"dbVersion": "v1.0.0",
"version": "<GIT_COMMIT>",
"logFileName": "access_log"
},
"kubernetes": {
"namespace": "default"
}
}
}
3 changes: 0 additions & 3 deletions config/local.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,5 @@
"dbVersion": "v1.0.0",
"version": "local",
"logFileName": "access_log"
},
"kubernetes": {
"namespace": "default"
}
}
3 changes: 0 additions & 3 deletions config/testing.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,5 @@
"dbVersion": "v1.0.0",
"version": "local",
"logFileName": "access_log"
},
"kubernetes": {
"namespace": "default"
}
}
2 changes: 2 additions & 0 deletions src/config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ type Config struct {

// the version settings of the current application
Version string `json:"version"`

Kubernetes string `json:"kubernetes"`
}

func Read(path string) (c Config, err error) {
Expand Down
25 changes: 8 additions & 17 deletions src/kubernetes/nodes_test.go
Original file line number Diff line number Diff line change
@@ -1,37 +1,28 @@
package kubernetes

import (
"github.com/linkernetworks/config"
"github.com/linkernetworks/service/kubernetes"
"github.com/linkernetworks/kubeconfig"
"github.com/stretchr/testify/assert"
"os"
"k8s.io/client-go/kubernetes"
"testing"
)

func TestGetNodeFail(t *testing.T) {
if _, ok := os.LookupEnv("TEST_K8S"); !ok {
t.SkipNow()
}
config, err := kubeconfig.Load("")
assert.NoError(t, err)

kubernetes := kubernetes.NewFromConfig(&config.KubernetesConfig{
Namespace: "default",
})
clientset, err := kubernetes.NewClientset()
clientset, err := kubernetes.NewForConfig(config)
assert.NoError(t, err)

_, err = GetNode(clientset, "UnKnown_Name")
assert.Error(t, err)
}

func TestGetNodes(t *testing.T) {
if _, ok := os.LookupEnv("TEST_K8S"); !ok {
t.SkipNow()
}
config, err := kubeconfig.Load("")
assert.NoError(t, err)

kubernetes := kubernetes.NewFromConfig(&config.KubernetesConfig{
Namespace: "default",
})
clientset, err := kubernetes.NewClientset()
clientset, err := kubernetes.NewForConfig(config)
assert.NoError(t, err)

_, err = GetNodes(clientset)
Expand Down
21 changes: 13 additions & 8 deletions src/serviceprovider/serviceprovider.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,17 @@ import (
"github.com/linkernetworks/logger"
"github.com/linkernetworks/vortex/src/config"

"github.com/linkernetworks/kubeconfig"
"github.com/linkernetworks/mongo"
"github.com/linkernetworks/redis"
"github.com/linkernetworks/service/kubernetes"
"k8s.io/client-go/rest"
)

type Container struct {
Config config.Config
Redis *redis.Service
Mongo *mongo.Service
Kubernetes *kubernetes.Service
Kubernetes *rest.Config
}

type ServiceDiscoverResponse struct {
Expand All @@ -32,13 +33,17 @@ func New(cf config.Config) *Container {
logger.Infof("Connecting to mongodb: %s", cf.Mongo.Url)
mongo := mongo.New(cf.Mongo.Url)

kubernetes := kubernetes.NewFromConfig(cf.Kubernetes)

sp := &Container{
Config: cf,
Redis: redisService,
Mongo: mongo,
Kubernetes: kubernetes,
Config: cf,
Redis: redisService,
Mongo: mongo,
}

if cf.Kubernetes == nil {
logger.Warnln("kubernetes service is not loaded: kubernetes config is not defined.")
} else {
config, _ := kubeconfig.Load(cf.Kubernetes)
sp.Kubernetes = config
}

return sp
Expand Down

0 comments on commit 14618ed

Please sign in to comment.