Add the testing for empty data

src/server/handler_storage_provider.go

@@ -28,7 +28,6 @@ func CreateStorageProvider(ctx *web.Context) {
 	query := bson.M{"displayName": storageProvider.DisplayName}
 	count, err := session.Count(entity.StorageProviderCollectionName, query)
 	if err != nil && err.Error() != mgo.ErrNotFound.Error() {
-		logger.Error(err)
 		response.InternalServerError(req.Request, resp.ResponseWriter, err)
 		return
 	}
@@ -40,7 +39,6 @@ func CreateStorageProvider(ctx *web.Context) {
 	storageProvider.ID = bson.NewObjectId()
 	storageProvider.CreatedAt = timeutils.Now()
 	if err := session.Insert(entity.StorageProviderCollectionName, &storageProvider); err != nil {
-		logger.Error(err)
 		response.InternalServerError(req.Request, resp.ResponseWriter, err)
 		return
 	}

src/server/handler_storage_provider_test.go

@@ -46,6 +46,19 @@ func TestCreateStorageProvider(t *testing.T) {
 	service := newStorageProviderService(sp)
 	wc.Add(service)
 	wc.Dispatch(httpWriter, httpRequest)
-	defer session.Remove(entity.StorageProviderCollectionName, "displayName", tName)
 	assertResponseCode(t, http.StatusOK, httpWriter)
+	//Empty data
+	//We use the new write but empty input
+	httpWriter = httptest.NewRecorder()
+	wc.Dispatch(httpWriter, httpRequest)
+	assertResponseCode(t, http.StatusBadRequest, httpWriter)
+	//Create again and it should fail since the name exist
+	bodyReader = strings.NewReader(string(bodyBytes))
+	httpRequest, err = http.NewRequest("POST", "http://localhost:7890/v1/storageprovider", bodyReader)
+	assert.NoError(t, err)
+	httpRequest.Header.Add("Content-Type", "application/json")
+	httpWriter = httptest.NewRecorder()
+	wc.Dispatch(httpWriter, httpRequest)
+	assertResponseCode(t, http.StatusConflict, httpWriter)
+	defer session.Remove(entity.StorageProviderCollectionName, "displayName", tName)
 }