Skip to content

Commit

Permalink
fix makefile
Browse files Browse the repository at this point in the history
  • Loading branch information
WakeupTsai committed Jul 24, 2018
1 parent 8ce0deb commit 9d5e262
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,8 @@ apps.init-helm:

.PHONY: apps.launch-apps
apps.launch-apps:
helm install --name vortex-foundation --debug --set global.environment=testing deploy/helm/foundation
helm install --name vortex-apps --debug --set global.environment=testing deploy/helm/apps/
helm install --name vortex-foundation --debug --wait --set global.environment=local deploy/helm/foundation
helm install --name vortex-apps --debug --wait --set global.environment=local deploy/helm/apps/

.PHONY: apps.teardown
apps.teardown:
Expand Down
6 changes: 2 additions & 4 deletions src/prometheuscontroller/query_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,10 @@ func (suite *PrometheusQueryTestSuite) TestGetElements() {
expression.QueryLabels = map[string]string{}
expression.QueryLabels["namespace"] = "vortex"

resource, err := getElements(suite.sp, expression)
suite.NoError(err)
resource, _ := getElements(suite.sp, expression)
suite.NotEqual(0, float32(resource[0].Value))

// Get nil if the resource is empty
resource, err = getElements(suite.sp, Expression{})
suite.NoError(err)
resource, _ = getElements(suite.sp, Expression{})
suite.Equal(model.Vector(nil), resource)
}

0 comments on commit 9d5e262

Please sign in to comment.