Skip to content

Commit

Permalink
Merge pull request #305 from linkernetworks/phstsai/fixTravisBug
Browse files Browse the repository at this point in the history
[Bug] For travis debug
  • Loading branch information
John-Lin authored Aug 31, 2018
2 parents 561f37d + 690792b commit a69fd39
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
6 changes: 5 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,11 @@ jobs:
include:
- stage: "Tests"
name: "Unit Test"
script: make pre-build && sudo -E PATH=$PATH TEST_GRPC=1 TEST_PROMETHEUS=1 make src.test-coverage-minikube
script:
# DEBUG: first two lines is for debug
- kubectl get pods --all-namespaces
- kubectl get service --all-namespaces
- make pre-build && sudo -E PATH=$PATH TEST_GRPC=1 TEST_PROMETHEUS=1 make src.test-coverage-minikube
after_success:
- cp build/src/coverage.txt coverage.txt
- bash <(curl -s https://codecov.io/bash)
Expand Down
3 changes: 2 additions & 1 deletion src/prometheuscontroller/controller.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package prometheuscontroller

import (
"fmt"
"strconv"
"strings"

Expand Down Expand Up @@ -537,7 +538,7 @@ func GetService(sp *serviceprovider.Container, id string) (entity.ServiceMetrics
kc := sp.KubeCtl
object, err := kc.GetService(service.ServiceName, service.Namespace)
if err != nil {
return entity.ServiceMetrics{}, err
return entity.ServiceMetrics{}, fmt.Errorf("fail to get the ports setting of service %v in namespace %v: %v", service.ServiceName, service.Namespace, err)
}
service.Ports = object.Spec.Ports

Expand Down

0 comments on commit a69fd39

Please sign in to comment.